search

ApolloZhu / Dynamic-Dark-Mode

The smart, automatic Dark Mode toggle for macOS Mojave+
https://apollozhu.github.io/Dynamic-Dark-Mode/
GNU General Public License v3.0
504 stars 31 forks source link

dynamic mode based on brightness doesn't work latest macbook #46

Closed idoo closed 5 years ago

idoo commented 5 years ago

Looks like something broken on latest MacBook with touch bar (maybe it's because the controller of brightness has been moved to T2 chip)

Do you have any ideas how to solve it?

ApolloZhu commented 5 years ago

If your Mac has an ambient light sensor, choose Apple menu > System Preferences, click Displays, then click Display, then select “Automatically adjust brightness.” Could you please try this first?

idoo commented 5 years ago
built-in retina display 2018-12-08 14-35-19

it set by default

ApolloZhu commented 5 years ago

I actually experienced this myself today. Can you try to first disable then enable Auto Adjust within Dynamic Dark Mode and see if that works?

idoo commented 5 years ago

nope :( still the same result :(

btw, how you detect the brightness?

ApolloZhu commented 5 years ago

https://github.com/ApolloZhu/Dynamic-Dark-Mode/blob/master/Dynamic/Utilities/Brightness/NSScreen%20%2B%20Brightness.swift handles that.

And there is a bug that when there are more than one displays, the program can’t determine the current brightness value.

idoo commented 5 years ago

so, it is based on display brightness, not light sensor, right?

ApolloZhu commented 5 years ago

Yes

idoo commented 5 years ago

it makes sense, because as I understand there is no way to get value from the light sensor on macs with T1 and T2 chips, because it used private API that doesn't works anymore (it still works well on mac without touchbar btw)

ApolloZhu commented 5 years ago

Okay....

I’ll try to find a Mac that I can test on and see if there’s a way to solve this problem

idoo commented 5 years ago

let me know if I can help you somehow, I have a mac with T2 chip

https://stackoverflow.com/a/18614019 there was a way to read such data from an Ambilight sensor (you still can use it for old MacBooks), but there are not AppleLMUController anymore ¯_(ツ)_/¯

So, I'll appreciate if you can find some way to read it

ApolloZhu commented 5 years ago

I don't think https://github.com/ApolloZhu/Dynamic-Dark-Mode/releases/tag/1.1.1 helps much, but it did solve the problem for me myself. Can you try this new version and see what happens?

ApolloZhu commented 5 years ago

@idoo I just tested the 1.1.1 release on my friend's new MacBook Pro 2018 with touch bar and it works perfectly. You should try it out and see if it works or not. Or you can describe your situation in more details so I may find out what other things could have caused the problem.

idoo commented 5 years ago

sorry, didn't respond, yes, it works perfectly now! thanks!