Inconsistent version number

ApolloZhu / Dynamic-Dark-Mode

The smart, automatic Dark Mode toggle for macOS Mojave+

https://apollozhu.github.io/Dynamic-Dark-Mode/

GNU General Public License v3.0

504 stars 31 forks source link

Inconsistent version number #56

Closed core-code closed 5 years ago

core-code commented 5 years ago

i've downloaded Version '1.1.3' (both the ZIP and the PKG) but when selecting it in the Finder and using 'QuickLook' it shows Version '1.1'

you have forgot to update the CFBundleShortVersionString and CFBundleVersion entries in the Info.plist

core-code commented 5 years ago

additionally the CFBundleVersion has been lower for the 1.1 release than for previous releases. the CFBundleVersion value should increase for each new release as per Apple's rules. for Apps distributed on the Mac App Store this rule is even enforced technically.

this should fix it:

    <key>CFBundleShortVersionString</key>
    <string>1.1.3</string>
    <key>CFBundleVersion</key>
    <string>1.1.3</string>

ApolloZhu commented 5 years ago

Technically the current version 1.1 (3) but I’ll switch to the other style.

core-code commented 5 years ago

awesome, thanks!

andrewmincn commented 5 years ago

why can't down

ApolloZhu commented 5 years ago

@andrewmincn install via Homebrew (https://brew.sh/) using this command:

brew cask install dynamic-dark-mode

or download the pkg/zip file from this page: https://github.com/ApolloZhu/Dynamic-Dark-Mode/releases/latest