search

ApolloZhu / Dynamic-Dark-Mode

The smart, automatic Dark Mode toggle for macOS Mojave+
https://apollozhu.github.io/Dynamic-Dark-Mode/
GNU General Public License v3.0
504 stars 31 forks source link

Scheduling not working properly #57

Closed brookssolveig closed 5 years ago

brookssolveig commented 5 years ago

I'm sure how to title this issue because I'm not certain what the problem is. My situation, as you'll see in the screenshot, is that night mode is triggered before the scheduled time. You can see that despite having selected Dark Mode On Between Official Sunset Sunrise (5:59 PM – 6:42 AM), it has triggered at 5:20 PM. I'd like to add that I love your product – thanks for making and maintaining it 🙏🏻 ![Uploading Screenshot 2019-02-26 17.20.56.png…]()

ApolloZhu commented 5 years ago

I can’t see the screen shot but what could have happened here is Dark Mode been turned on because screen brightness is below the triggering threshold. Do you think that might be the cause?

brookssolveig commented 5 years ago

I don't believe that brightness has anything to do with it. I've turned off automatic brightness, and I just caught it switching too early again without any brightness changes. Here's a link to the screenshot instead of an attachment.

ApolloZhu commented 5 years ago

I can't think of a reason why that would happen, but I'll take a look at the code and try to see if there's anything wrong with it. Maybe you can try the latest release (1.1.4) and see if it fixes the problem. 1.1 (3) and earlier versions all have the problem that it'll schedule whenever your Mac awakes from sleep. But I think that and the situation you described are unrelated.

By the way the link is still not working, it's not publicly shared.

brookssolveig commented 5 years ago

Looks like I was on an outdated version. Updated and I'll let you know if this behavior persists.

ApolloZhu commented 5 years ago

Please reopen the issue if this happens again.

brookssolveig commented 5 years ago

Hey, not sure how to re-open this, but I'm still having the schedule issue. Prefs say 8:30 pm but it's 5:20 pm and it flipped out. Been happening regularly. Running v1.1.4 on MacOS 10.14.5 (18F132).

ApolloZhu commented 5 years ago

Do you mind trying out 1.3.0?

ApolloZhu commented 5 years ago

And, does this happen immediately after you open/login/wake up your computer?

brookssolveig commented 5 years ago

Hey there, I'll try 1.3.0. Currently, I'm on still on v1.1.4. At 5:30 PM on my shuttle ride home it switched on its own again. I'll report back after a few days on v1.3.0.

brookssolveig commented 5 years ago

Hey there, I've been on 1.3.0 for some time now and I'm still experiencing this issue.

I want to add another piece of information, in case it's helpful. Around the time that Dark Mode is triggered I'm also boarding a shuttle home from work that has wifi. This could be related or not.

Are there logs that I can provide you that would be helpful?

brookssolveig commented 5 years ago

Indeed, the switch to dark mode appears to correspond with my move to my shuttle. Today the switch occurred at 5:11 PM PDT, after boarding the shuttle and opening my laptop. Oddly, I had not yet switched to shuttle wifi.

brookssolveig commented 5 years ago

I'd like to add that it seems Dynamic Dark mode begins cycling between day and night modes when I board my shuttle. This slows my computer down until I quit the plugin.

ApolloZhu commented 5 years ago

A recent change in Dynamic Dark Mode updates appearance on network condition change, so it sounds like the Wi-Fi on your shuttle provides inaccurate location information... I'll see how I should approach this...

Sorry for the late reply... My old computer broke and I just got hands on the new one yesterday.

brookssolveig commented 5 years ago

Dude you're all good. Still really appreciate that you support this app actively.

On Sun, Sep 8, 2019 7:11 AM, ApolloZhu notifications@github.com wrote: A recent change in Dynamic Dark Mode updates appearance on network condition change, so it sounds like the Wi-Fi on your shuttle provides inaccurate location information... I'll see how I should approach this...

Sorry for the late reply... My old computer broke and I just got hands on the new one yesterday.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

⚡️ Brooks Hassig / Product Designer, Facebook

ApolloZhu commented 5 years ago

Actually, now I'm in Seattle I'm able to reproduce/debug this issue myself. Thanks for your support and reporting this bug. It will be fixed in the next release

ApolloZhu commented 5 years ago

Finally, it should be fixed. Update to 1.5.2 and see if it works ;)