search

ApolloZhu / Dynamic-Dark-Mode

The smart, automatic Dark Mode toggle for macOS Mojave+
https://apollozhu.github.io/Dynamic-Dark-Mode/
GNU General Public License v3.0
504 stars 31 forks source link

Switching to dark mode at sunrise #60

Open owenzhao opened 5 years ago

owenzhao commented 5 years ago

Version 1.1.4 (0)

Auto Adjust: uncheck Scheduled: checked with Official Sunset Sunrise.

When I manually switch to bright mode in the morning, this app turns it to dark mode again when the Sun up time comes.

I think it will be the best to check if the mode is already the desired one before switching.

ApolloZhu commented 5 years ago

The tricky part is, what would be the desired display mode? But your case sounds more like a simpler bug to me. The app should switch to bright mode regardless of the current state in the morning.

I’ll try to reproduce this scenario and see what could be wrong. Please let me know if this happens again.

ApolloZhu commented 5 years ago

Seems to be related to #57 ?

owenzhao commented 5 years ago

I think the setting has already suggested what the desired mode is, as it says "Dark Mode On Between".

AgTyPU.md.png

I had read #57 before I filed this issue. I don't think it is related. He turned off the auto brightness. But it seemed to me that was the display setting of the macOS, not the setting of this app.

ApolloZhu commented 5 years ago

I rewrote the theme switching code a little and hope that solves the problem. Please reopen this issue if the program still switches theme to dark mode at sunrise.