search

Apollon77 / hap-controller-node

Node.js library to implement a HAP (HomeKit) controller
Mozilla Public License 2.0
54 stars 16 forks source link

Pair setup change #32

Closed Apollon77 closed 3 years ago

Apollon77 commented 3 years ago

This PR addresses #31 by adding support to optionally provide the PairMethod and also ParingTypeFlags available when using PairSetup method.

My Hue is pairing fine.

I hope I did anything correct in Typescript

Apollon77 commented 3 years ago

Sure, template strings are much beter, I just "followed the style" you used in one of the exmaple files :-)

Apollon77 commented 3 years ago

I also let prettify run and fixed eslint stuuff again :-)

minamoanes commented 2 years ago

Hello, I'm still facing this issue:

/homebridge/node_modules/homebridge-homekit-control/node_modules/hap-controller/lib/protocol/pairing-protocol.js:272
            throw new Error('M4: Empty TLV');
                  ^

Error: M4: Empty TLV
    at PairingProtocol.parsePairSetupM4 (/homebridge/node_modules/homebridge-homekit-control/node_modules/hap-controller/lib/protocol/pairing-protocol.js:272:19)
    at HttpClient.finishPairing (/homebridge/node_modules/homebridge-homekit-control/node_modules/hap-controller/lib/transport/ip/http-client.js:128:36)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async HttpClient.pairSetup (/homebridge/node_modules/homebridge-homekit-control/node_modules/hap-controller/lib/transport/ip/http-client.js:150:9)
    at async /homebridge/node_modules/homebridge-homekit-control/cli.js:134:17

any ideas?

Apollon77 commented 2 years ago

Responsind on an issue which is closed since 10months is not the best idea ... Please open a new issue with etaisl to the device and ideally an enhanced debug log (see readme for instructions). Then we can analysze it in more detail