search

Apollon77 / node-mbus

Nodejs mbus module
MIT License
20 stars 15 forks source link

Timeouts of libmbus are too short on some cases #70

Closed tsr8 closed 1 year ago

tsr8 commented 3 years ago

In my project I need longer timeouts in libmbus to work properly.

I can change source of libmbus and compile it and test it but: how to compile node-mbus (need it in node-red)?

Resolved by myself using node-gyp: node-gyp install node-gyp configure node-gyp build

Apollon77 commented 3 years ago

WHy you do not make a PR in the libmbus project to have it adjusted there?

tsr8 commented 3 years ago

Thank you for the answer. They already have special "adjustable-timeout" branch for this, which adds "-t" parameter. I have created an libmbus issue: https://github.com/rscada/libmbus/issues/186 I think that node-mbus shoud provide some setting to change timeouts easy way.

Apollon77 commented 3 years ago

In fact thet PR is aloready included in their project and also in mine

https://github.com/Apollon77/libmbus/blob/build-windows/mbus/mbus-serial.c#L155

you need even higher values?

tsr8 commented 3 years ago

you need even higher values?

By testing, I need minimum 1100ms at 2400 baudrate. It fails with 1000ms.

Apollon77 commented 3 years ago

yes so it only makes sense to make it configurable completely ... puhhh ...

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions. Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

Apollon77 commented 2 years ago

Timeout in generlsa can be ast as options.timeout already ... doyou reallyneed to adjust these "sub timeouts" or is the normalone enougth? Did you tried that?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions. Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

stale[bot] commented 1 year ago

This issue has been automatically closed because of inactivity. Please open a new issue if still relevant and make sure to include all relevant details, logs and reproduction steps. Thank you for your contributions. Dieses Problem wurde aufgrund von Inaktivität automatisch geschlossen. Bitte öffnet ein neues Issue, falls dies noch relevant ist und stellt sicher das alle relevanten Details, Logs und Reproduktionsschritte enthalten sind. Vielen Dank für Eure Unterstützung.