ApollosProject / apollos-embeds

Apollos React Embeds that can be used in Webflow and other third-party websites.
https://www.npmjs.com/package/@apollosproject/apollos-embeds
0 stars 0 forks source link

fix: Ensure scroll to top on content change #152

Closed vinnyjth closed 10 months ago

vinnyjth commented 10 months ago

🐛 Issue

https://3.basecamp.com/3926363/buckets/32694519/card_tables/cards/6979824029

✏️ Solution

Make sure, when navigating, that we are sent to the top of the change when moving between content items. We do this by scrolling the modal to the top every time the modal content changes.

🔬 To Test

  1. Open up any feed.
  2. Tap on any item that's a series
  3. Tap on any of the children / sibling items.

This may work for you on web-embeds.

http://localhost:3001/?id=jesus-gen-z-TWVkaWFDb250ZW50SXRlbS0zZTI5ZWRiZC05NGU0LTQxZDgtODdjOC1iNzdkYmVmN2U2ZWY%3D

📸 Screenshots

https://github.com/ApollosProject/apollos-embeds/assets/1637694/be04ef3f-42f6-45b5-a72c-52a172d38eb1

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apollos-micro-service ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 8:20pm
apollos-web-embeds ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 8:20pm
nlewis84 commented 10 months ago

merge conflicts on index