ApollosProject / apollos-embeds

Apollos React Embeds that can be used in Webflow and other third-party websites.
https://www.npmjs.com/package/@apollosproject/apollos-embeds
0 stars 0 forks source link

chore: update regex for more valid scripture feature references #155

Closed nlewis84 closed 10 months ago

nlewis84 commented 10 months ago

🐛 Issue

Some scripture features are bombing out in web-embeds but not in mobile/admin

✏️ Solution

🔬 To Test

  1. Start the micro-service by yarn dev in the /micro-service folder
  2. Nav to http://localhost:3000/?id=UniversalContentItem-8aa3cff4-5054-4464-b1dc-e2e31c5adf1d
  3. See 4 example ScriptureFeatures working correctly
  4. If you want to verify on the mobile app, use Apollos Demo, head to the Explore tab, check out the last feature and tap on Psalm 100 Devotional

📸 Screenshots

Before
Screenshot 2024-01-30 at 5 13 45 PM
---
After
Screenshot 2024-01-30 at 5 49 08 PM
After photos for mobile and web to show parity Mobile Web
html styling web
header styling mobile
vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apollos-micro-service ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:44pm
apollos-web-embeds ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:44pm
nlewis84 commented 10 months ago

@vinnyjth I will work on this description. Discovered this issue while hooking up ScriptureFeatures on Admin. I dropped the before/after photos in the description already. Ideally, I think I would also like to make sure the padding/margin around scripture features on embeds matches mobile. My gut says it is probably too compact here.

vinnyjth commented 10 months ago

@nlewis84 Sounds good! long term, I wonder if we should expose this from the API :D

nlewis84 commented 10 months ago

@nlewis84 Sounds good! long term, I wonder if we should expose this from the API :D

Yeah, I think you are right on long term plan for it.