search

ApollosProject / apollos-embeds

Apollos React Embeds that can be used in Webflow and other third-party websites.
https://www.npmjs.com/package/@apollosproject/apollos-embeds
0 stars 0 forks source link

Upgrade phosphor #185

Closed conrad-vanl closed 8 months ago

conrad-vanl commented 8 months ago

🐛 Issue

Phosphor is outdated and need new icons in event block pr

✏️ Solution

Update phoshpor

Note on the PR size:

  1. Workspaces weren't properly setup, which was messing with dependencies across the packages. The workspace was kinda setup, but anytime yarn did something it spit out a warning aobut workspaces only working on private packages. so I made the base package.json private and it snapped into order
  2. There were lint/format issues in some of the files and so the formatting got updated upon save. I can try to revert these changes if too heavy handed

🔬 To Test

1. 3.

📸 Screenshots

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apollos-micro-service ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 6:07pm
apollos-web-embeds ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 6:07pm
conrad-vanl commented 8 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @conrad-vanl and the rest of your teammates on Graphite Graphite

nlewis84 commented 8 months ago

My testing instructions were:

conrad-vanl commented 8 months ago

Merge activity