ApollosProject / apollos-embeds

Apollos React Embeds that can be used in Webflow and other third-party websites.
https://www.npmjs.com/package/@apollosproject/apollos-embeds
0 stars 0 forks source link

Add Event Block #186

Closed conrad-vanl closed 9 months ago

conrad-vanl commented 9 months ago

🐛 Issue

No event block in web, part of cycle goals

✏️ Solution

Add event block

https://github.com/ApollosProject/apollos-embeds/assets/103927/151dc085-931d-40ab-81bf-fe7bab49768e

🔬 To Test

  1. On staging admin create a content item with an event block
  2. While pointed at staging, open that content item in the web service

📸 Screenshots

CleanShot 2024-02-29 at 16 07 09@2x

CleanShot 2024-02-29 at 16 07 38@2x

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apollos-micro-service ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 7:47pm
apollos-web-embeds ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 7:47pm
conrad-vanl commented 9 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @conrad-vanl and the rest of your teammates on Graphite Graphite

nlewis84 commented 9 months ago

Should have just used pentagram for Outlook. Missed opportunity.

conrad-vanl commented 9 months ago

@nlewis84 are you running https://github.com/ApollosProject/apollos-cluster/pull/917 locally and pointing embeds at that?

conrad-vanl commented 9 months ago

Forgot to list that as requirement. And that has to be merged and released first anyways

nlewis84 commented 9 months ago

Ah nope, I wasn't. That would do it.

nlewis84 commented 9 months ago

These three event blocks (something in there) gives me the following error in web-embeds: Screenshot 2024-03-01 at 12 53 58 PM Screenshot 2024-03-01 at 12 54 10 PM

nlewis84 commented 9 months ago

Probably that text for multi line location. Should we have validation in Admin?

nlewis84 commented 9 months ago

Hmmm, yeah a text location (think like "Virtual" or "Spring Creek Campus") will break the convertToIcsLink and convertAddressToGoogleMapLink functions. With some selective commenting, I can get them to show up and they look like this. Any adjustments you would like to make for styling?

Also, there should be a title on that 3rd one but it doesn't come through.

Screenshot 2024-03-01 at 1 08 17 PM

conrad-vanl commented 9 months ago

@nlewis84 just pushed up some changes see if that helps

conrad-vanl commented 9 months ago

yeah i agree, but i didn't like the other shadows either and didn't want to define a new one