Closed conrad-vanl closed 9 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
apollos-micro-service | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 1, 2024 7:47pm |
apollos-web-embeds | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 1, 2024 7:47pm |
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @conrad-vanl and the rest of your teammates on Graphite
Should have just used pentagram
for Outlook. Missed opportunity.
@nlewis84 are you running https://github.com/ApollosProject/apollos-cluster/pull/917 locally and pointing embeds at that?
Forgot to list that as requirement. And that has to be merged and released first anyways
Ah nope, I wasn't. That would do it.
These three event blocks (something in there) gives me the following error in web-embeds:
Probably that text for multi line location. Should we have validation in Admin?
Hmmm, yeah a text location (think like "Virtual" or "Spring Creek Campus") will break the convertToIcsLink
and convertAddressToGoogleMapLink
functions. With some selective commenting, I can get them to show up and they look like this. Any adjustments you would like to make for styling?
Also, there should be a title on that 3rd one but it doesn't come through.
@nlewis84 just pushed up some changes see if that helps
yeah i agree, but i didn't like the other shadows either and didn't want to define a new one
🐛 Issue
No event block in web, part of cycle goals
✏️ Solution
Add event block
https://github.com/ApollosProject/apollos-embeds/assets/103927/151dc085-931d-40ab-81bf-fe7bab49768e
🔬 To Test
📸 Screenshots