ApollosProject / apollos-embeds

Apollos React Embeds that can be used in Webflow and other third-party websites.
https://www.npmjs.com/package/@apollosproject/apollos-embeds
0 stars 0 forks source link

Fix: issue while scroll search list #194

Closed rajitharussel closed 7 months ago

rajitharussel commented 8 months ago

🐛 Issue

Closes #183 the search results container does not update when input focused but keyboard hidden.

183

✏️ Solution

updated container height to 100vh so issue will not happen

🔬 To Test

  1. open web-embed application and focus on search bar. and then scroll up starting from the bottom while keyboard is hidden.

📸 Screenshots

https://github.com/ApollosProject/apollos-embeds/assets/138706838/ad226b39-75b0-462f-90aa-35c3c5c01a90

https://github.com/ApollosProject/apollos-embeds/assets/138706838/c76e6064-40eb-4391-a6c6-a53f82782287

Screenshot 2024-03-07 at 19 39 59
vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apollos-micro-service ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2024 3:09am
apollos-web-embeds ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2024 3:09am
vinnyjth commented 8 months ago

@rajitharussel can you include a picture of the search box opening on a desktop sized window? Thank you!

rajitharussel commented 8 months ago

@rajitharussel can you include a picture of the search box opening on a desktop sized window? Thank you!

updated

redreceipt commented 8 months ago

@rajitharussel this has been sitting for three weeks, please make sure there is a requestor selected and PRs are moving along. If you don't know who to add, add me.

rajitharussel commented 8 months ago

@rajitharussel this has been sitting for three weeks, please make sure there is a requestor selected and PRs are moving along. If you don't know who to add, add me.

got it.

redreceipt commented 7 months ago

@vinnyjth @conrad-vanl could one of you verify this? Seems simple enough but my CSS is no good.