The alternative jigsaw is smaller than jigsaw from vanilla

Apollounknowndev / lithostitched

A library mod with new configurability and compatibility enhancements for worldgen

MIT License

6 stars 2 forks source link

The alternative jigsaw is smaller than jigsaw from vanilla #6

Closed SettingDust closed 1 month ago

SettingDust commented 5 months ago

The 3 bottom is lithostitched:jigsaw and the 2 top is minecraft:jigsaw

The structure is https://github.com/ChoiceTheorem/ChoiceTheorem-s-overhauled-village/blob/1.20/common/src/main/resources/data/ctov/worldgen/structure/large/village_beach.json

Apollounknowndev commented 5 months ago

Can't replicate with vanilla structures.

Vanilla jigsaw above, Lithostitched jigsaw below

The upper structures in your image actually look like they're too big, as a size of 5 shouldn't allow them to reach that limit. No clue what that is about though.

SettingDust commented 5 months ago

I tried removing the injection but got the same result. Is there some hint for this? @ChoiceTheorem

EDIT: Same with 1.1.5. NTW, the injection is fixed.

SettingDust commented 5 months ago

Failing to figure out the reason. I think I changed nothing.

The instance exported with Prism Launcher CTOV Datapacks.zip

ChoiceTheorem commented 5 months ago

Hmmm, indeed they are identical. The different are structure type. Have no idea why it doesn't work with CTOV though.

Apollounknowndev commented 3 months ago

Unintentionally found and fixed the bug while working on the 1.20.5 update, will be backporting and releasing the fix in 1.1.6.

SettingDust commented 3 months ago

Unintentionally found and fixed the bug while working on the 1.20.5 update, will be backporting and releasing the fix in 1.1.6.

wow. I'm looking forward to the fix push to Github, I want to see the reason

Apollounknowndev commented 3 months ago

The difference is changing a single word, it's so unbelievably stupid

Apollounknowndev commented 1 month ago

Completely forgot about this until just now :P 1.1.6 rolling out now.

SettingDust commented 1 month ago

Completely forgot about this until just now :P 1.1.6 rolling out now.

@Apollounknowndev The code on Github won't update?

Apollounknowndev commented 1 month ago

Pushed

SettingDust commented 1 month ago

So, return to continue XD. lul