Good evening. Before anything, thanks for your work on this datapack. Truly stellar stuff.
When loading this datapack on a server, the log becomes spammed with a single log message repeatedly, and it causes the console to become completely unreadable and thus unreliable. Here is the message below:
This error message is complaining about the incorrect usage of a minecraft:max function, saying that there is no overlap between the two parameters, with one being -0.75 and the other being this massive function that is, what I presume to be, driving this entire density function. I've tested this datapack on Fabric, Forge, and NeoForge, and can confirm it happens indiscriminately on all three of those mod loaders.
By tracking down the usage of -0.75, I found the source of the problem to be the modification of minecraft:overworld/offset and minecraft:overworld_large_biomes/offset density functions. I do not know if the intention was to have the function type be minecraft:min rather than minecraft:max, but removing it altogether also solves this problem. Here are my patch diffs of my changes for your ease of access.
Patching the density functions like this causes the warning to stop spawning in the console. There also seems to be no adverse side effects in the terrain generation (although, it's not my expertise so you should test that yourself) and the console had generated no other errors.
All in all, and with all due respect, please test your datapacks on the version you will be posting them for before you do so. 🫡
I posted a fix for this issue on Modrinth a few days ago with 2.4.0a. Forgot to update it on Curseforge so if you downloaded the pack from there than that's on me
Good evening. Before anything, thanks for your work on this datapack. Truly stellar stuff.
When loading this datapack on a server, the log becomes spammed with a single log message repeatedly, and it causes the console to become completely unreadable and thus unreliable. Here is the message below:
This error message is complaining about the incorrect usage of a
minecraft:max
function, saying that there is no overlap between the two parameters, with one being-0.75
and the other being this massive function that is, what I presume to be, driving this entire density function. I've tested this datapack on Fabric, Forge, and NeoForge, and can confirm it happens indiscriminately on all three of those mod loaders.By tracking down the usage of
-0.75
, I found the source of the problem to be the modification ofminecraft:overworld/offset
andminecraft:overworld_large_biomes/offset
density functions. I do not know if the intention was to have the function type beminecraft:min
rather thanminecraft:max
, but removing it altogether also solves this problem. Here are my patch diffs of my changes for your ease of access.Patching the density functions like this causes the warning to stop spawning in the console. There also seems to be no adverse side effects in the terrain generation (although, it's not my expertise so you should test that yourself) and the console had generated no other errors.
All in all, and with all due respect, please test your datapacks on the version you will be posting them for before you do so. 🫡
Minecraft 1.21 Tectonic 2.4.0