Apollounknowndev / tectonic

Enhanced terrain generation with mountain ranges, underground rivers, and more
81 stars 9 forks source link

Terralith's scarlet mountains turn to dirt mountains with Tectonic increased world height #177

Closed johalun closed 1 month ago

johalun commented 3 months ago

MC 1.20.1 Forge 47.2.32 Tectonic 2.3.5a (mod) Terralith 2.5.1 (mod)

Tectonic has a config option "increased_height" which increases the world height to 640. When setting this to true, what used to be Terralith's scarlet mountains becomes just dirt/stone mountains. The terrain itself looks very similar regardless of this setting but the blocks are changed. The biome is still scarlet mountains.

https://github.com/Stardust-Labs-MC/Terralith/issues/133

TsameCorvy commented 3 months ago

Happens with Volcano Peaks as well. image

johalun commented 3 months ago

Is there a ETA on a potential fix? I don't mean to put stress on any devs at all, just wondering since we are planning to release a new modpack and would like to include this fix if it aligns with our planned release.

dasaikuru commented 2 months ago

2024-07-07_03 58 53 happens with painted mountains as well if you touch anything in the experimental portion of the config, this bug will occur

KaninchenSpeed commented 2 months ago

I found a fix, but I haven't tested if it has other implications.

Tested with: Terratonic v3.2 ~ 1.21 Terralith 1.21_v2.5.4 on seed -7609845261306572298

I deleted increased_height/data/minecraft/worldgen/noise_settings/large_biomes.json and replaced increased_height/data/minecraft/worldgen/noise_settings/overworld.json with data/minecraft/worldgen/noise_settings/overworld.json from terralith and edited

"noise": {
    "height": 384,
    "min_y": -64,
    "size_horizontal": 1,
    "size_vertical": 1
}

to

"noise": {
    "height": 704,
    "min_y": -64,
    "size_horizontal": 1,
    "size_vertical": 1
}
Apollounknowndev commented 1 month ago

Fixed for a future release.

johalun commented 1 month ago

What version is the fix for this scheduled to be in?

Kaidokie commented 1 month ago

According to the changelog it's already been fixed for 1.21

johalun commented 1 month ago

Not 1.20.1?

Kaidokie commented 1 month ago

That's the version I'm using, and there hasn't been an update yet.

johalun commented 1 month ago

😞 Wish it was open source so we could see the change and apply it ourselves if 1.20.1 won't be fixed...

Apollounknowndev commented 1 month ago

😞 Wish it was open source so we could see the change and apply it ourselves if 1.20.1 won't be fixed...

You're on the Github page for Tectonic which has the source code? The source for the pre-1.21 mod, 1.21 mod, base datapack and base terratonic are all here.

johalun commented 1 month ago

Oh I see, the code is in other branches! I thought it was just for issue management since the main branch is empty. I've seen this with other mods and probably got this mixed up with that.

johalun commented 1 month ago

Any chance we can get the terralith fix in 1.20 also?

Apollounknowndev commented 1 month ago

A backport of the fix to 1.20.1 will happen at some point but it's going to take some time as I need to make larger architectural changes to the mod on pre-1.21 versions.

johalun commented 1 month ago

Awesome! I appreciate your efforts.

Apollounknowndev commented 1 month ago

Fixed in v2.4.1 for both 1.20.1 and 1.21.