search

ApoorvaJ / Papaya

A GPU-powered image editor (in the making)
MIT License
374 stars 33 forks source link

Add new image size preview. #16

Closed GreenLightning closed 8 years ago

GreenLightning commented 8 years ago

This is the initial implementation for the image size preview as suggested in #14.

Please review the code and tell me what you think.

I also want to make the colors configurable (so maybe don't merge yet).

ApoorvaJ commented 8 years ago

Code looks excellent.

Image should be centered vertically with respect to workspace, not window. Relevant code is in the scope // Center canvas in papaya_core.cpp. There is one magic number in there, but I'll be cleaning up the layout constants in code at some point in the future, so feel free to duplicate that constant for now.

Also, feel free to tweak the new preview shader if you fancy a different look.

GreenLightning commented 8 years ago

I fixed the centering and made the colors configurable. You can merge now, if you want to :)

ApoorvaJ commented 8 years ago

Thanks for the contribution!