search

AppBlade / AppBladeSDK

The SDK for AppBlade; iOS and Android
https://appblade.com
MIT License
23 stars 14 forks source link

Keychain Hotfix & Auto-Disabling #79

Closed andrewtremblay closed 11 years ago

andrewtremblay commented 11 years ago

Added some logic for the Keychain to more gracefully confirm that it can write to the application. Also taking out the NSAsserts, since that's interpreted as AppBlade crashing the app rather than telling the Devleopers that there's a configuration error.

andrewtremblay commented 11 years ago

Alright. That should be working as intended.

jamesdaniels commented 11 years ago

We just released a new version of the SDK, was this not included? Anything holding this up?

andrewtremblay commented 11 years ago

I just need another pair of eyes on it. Gotta make sure I'm not breaking anything with my fixes.

The testing branch is still incoming.

joe-goullaud commented 11 years ago

Other than that, the code looks good. Still needs to be tested to make sure it doesn't interfere with other uses of the keychain.

andrewtremblay commented 11 years ago

Well with the addition of the new keychain-nuking function, it definitely can interfere with the keychain. It's assumed that people will use that method at their own discretion.

andrewtremblay commented 11 years ago

Spoke with Joe offline about the new additions and where to go in. We both agree that this can be pulled in.