PLCrashReporter Update (version 1.2-rc2)

[andrewtremblay]

Updating to 64-bit compatible crash reporting for new devices.

Pulling out old CrashReporter source and reintegrated the entire framework source. Rewrote the lipo script.

Resolved some deprecations to run better on iOS 7.

[andrewtremblay]

Looks good to me! I'm pulling this in.

[landonf]

Hi Andrew --

Just randomly stumbled across this in a GitHub search, I hope you won't mind a few comments:

• PLCF_RELEASE_BUILD=1 should be set, or a number of unsafe code paths will be enabled in the crash reporter.
• You probably want to define a PLCRASHREPORTER_PREFIX value (see PLCrashReporterNamespace.h) to change the symbol prefix used by PLCrashReporter's public symbols
• PLCrashReporter's Xcode project uses symbol stripping to avoid exposing internal symbols (including the protobuf-c symbols); you may want to reproduce this behavior to avoid symbol conflicts with other libraries.
• The private PLCrashReporter methods were always private and the behavior there is scheduled to change in an upcoming release, so I'd recommend transitioning away from them eventually if you can.

That's about all I can think of offhand. I'd also recommend eventually moving to using the PLCrashReporter project's build system directly if you can, since there are a lot of subtle pitfalls when trying to embed the sources and there will probably be more going forward (I may have missed a few above).

Hope that's of some (or any) help.

[andrewtremblay]

Thanks for the input Landon!

This is really just a hotfix to the current incarnation of our SDK, which I admit does use the PLCrashReporter source code in a rather rudimentary way. This was mostly due to issues with older versions of Xcode.

As both PLCrashReporter and AppBlade grow more sophisticated, we'll likely just embed the PLCrashReporter project file directly (which was something I considered doing in this release). For now though, I'll definitely use that build flag you mentioned.

My next iteration of the AppBlade SDK (SDK_rewrite_blocks) will take your suggestions more to heart. I promise.

[landonf]

Cheers!