AppDevNext / AndroidChart

A fork from dead upstream with a lot of merged pull requests from upstream. Including Espresso tests and screenshot tests
Other
113 stars 16 forks source link

allowBackup/supportsRtl is set inside the AndroidChart module #192

Closed frankois1234 closed 10 months ago

frankois1234 commented 10 months ago

Hello, I got in the latest version of AndroidChart this error. Can you can it in your module, it shouldn't be included in your module manifest.

Thanks

/Users/..../DEV/..../androidApp/src/main/AndroidManifest.xml:9:9-36 Error:
    Attribute application@allowBackup value=(false) from AndroidManifest.xml:9:9-36
    is also present at [com.github.AppDevNext:AndroidChart:3.1.0.19] AndroidManifest.xml:8:9-35 value=(true).
    Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:7:5-45:19 to override.
/Users/..../DEV/..../androidApp/src/main/AndroidManifest.xml:18:9-36 Error:
    Attribute application@supportsRtl value=(false) from AndroidManifest.xml:18:9-36
    is also present at [com.github.AppDevNext:AndroidChart:3.1.0.19] AndroidManifest.xml:9:9-35 value=(true).
    Suggestion: add 'tools:replace="android:supportsRtl"' to <application> element at AndroidManifest.xml:7:5-45:19 to override.
hannesa2 commented 10 months ago

Yes this makes no sense https://github.com/AppDevNext/AndroidChart/pull/193

hannesa2 commented 10 months ago

https://github.com/AppDevNext/AndroidChart/releases/tag/3.1.0.20