AppDevNext / AndroidChart

A fork from dead upstream with a lot of merged pull requests from upstream. Including Espresso tests and screenshot tests
Other
102 stars 15 forks source link

Add RoundedBar renderer for corner radius positive/negative BarChart #239

Closed hannesa2 closed 2 months ago

hannesa2 commented 2 months ago

… corner radius positive/negative Bar Chart

It's https://github.com/PhilJay/MPAndroidChart/pull/5420

close https://github.com/AppDevNext/AndroidChart/issues/237

hannesa2 commented 2 months ago

@Paget96

https://github.com/PhilJay/MPAndroidChart/pull/5420#issuecomment-2183028403

There is crash when we use FloatArray for Y values. Crash happens here, as we don't have y, instead yVals

if ((dataSet.getEntryForIndex(j / 4).y < 0 && roundedNegativeDataSetRadius > 0)) {

This is only needed to make it perfect

Where should be this applied ? Best would be a pull request

hannesa2 commented 2 months ago

Screenshot differs: 1

StartTest_smokeTestStart-20-PieChartActivity.pngscreenshot

Paget96 commented 2 months ago

@Paget96

https://github.com/PhilJay/MPAndroidChart/pull/5420#issuecomment-2183028403

There is crash when we use FloatArray for Y values. Crash happens here, as we don't have y, instead yVals

if ((dataSet.getEntryForIndex(j / 4).y < 0 && roundedNegativeDataSetRadius > 0)) {

This is only needed to make it perfect

Where should be this applied ? Best would be a pull request

It's for values on the bar chart. You can find this in the renderer file.

hannesa2 commented 2 months ago

It's for values on the bar chart. You can find this in the renderer file.

Sure. But current line differs. Is this the "shall be" or "current is" ? I'm confused

hannesa2 commented 2 months ago

This is the new test image