search

AppDevNext / AndroidChart

A fork from dead upstream with a lot of merged pull requests from upstream. Including Espresso tests and screenshot tests
Other
102 stars 15 forks source link

Disabling Legend makes X-axis labels leave component bounds #261

Open xxfogs opened 1 month ago

xxfogs commented 1 month ago

When chart legend gets disabled through

chart.legend.isEnabled = false

X-axis labels become just partially visible due to leaving the component bounds

image

I believe this issue has been inherited from the upstream as a similar issue has been filed recently

hannesa2 commented 1 month ago

Sure, as far as I know, this legend part is untouched. The only diff is here, that I merge pull requests and create immediate a new release

xxfogs commented 1 month ago

Do you maybe know any workarounds till a patch is released?

hannesa2 commented 1 month ago

No. To solve this systematically, a new espresso test, which demonstrates the issue is required.

hannesa2 commented 1 month ago

I tried to reproduce it https://github.com/AppDevNext/AndroidChart/pull/262 but here it's fine (at least for me) Please can you provide a running sample, best in this repo as a new sample ?

xxfogs commented 1 month ago

Yes, I will provide a sample repo, however can you please try moving the X axis in your test to bottom (chart.xAxis.position = XAxis.XAxisPosition.BOTTOM)? Currently it's on top

Test:

image

My sample:

image

hannesa2 commented 1 month ago

Yes, I will provide a sample repo,

Better, to do it in this repo as a pull request. Or simply jump into https://github.com/AppDevNext/AndroidChart/pull/262

hannesa2 commented 1 month ago

As I wrote https://github.com/AppDevNext/AndroidChart/pull/262#issuecomment-2260925482 I'm not able to reproduce