search

AppFlowy-IO / AppFlowy

Bring projects, wikis, and teams together with AI. AppFlowy is an AI collaborative workspace where you achieve more without losing control of your data. The best open source alternative to Notion.
https://www.appflowy.io
GNU Affero General Public License v3.0
56.78k stars 3.71k forks source link

[Bug] Trim text on sidebar with Ellipsis #1025

Closed richardshiue closed 2 years ago

richardshiue commented 2 years ago

Describe the bug I'm trying to implement elided text on the sidebar of the application. Currently, I've only made that change on pages, usernames and sub-pages. "Trash" and "New page" do not seem to ever get clipped by the sidebar (in all the existing languages at my resolution), so I've ignored them for now.

To Reproduce Steps to reproduce the behavior:

  1. Have a long username and/or page with very long names
  2. Resize the sidebar to the minimum
  3. The text goes on to the next line, or overflows. The second line is mostly visible, but the descenders get cut off. The third line is completely invisible

Concerns

  1. Do you guys have a particular design in mind?
  2. macOS has window control buttons in place of the appflowy logo. Does that decrease the minimum sidebar width?
  3. I'm not sure how this translates to other device resolutions.

Screenshots elided-text

Desktop

appflowy commented 2 years ago

I think it's ok to show the ellipsis if the text out of bound.