AppFlowy-IO / AppFlowy

Bring projects, wikis, and teams together with AI. AppFlowy is an AI collaborative workspace where you achieve more without losing control of your data. The best open source alternative to Notion.
https://www.appflowy.io
GNU Affero General Public License v3.0
58.32k stars 3.84k forks source link

[FR] Add a Video Player Plugin to AppFlowy Editor #1067

Open annieappflowy opened 2 years ago

annieappflowy commented 2 years ago

1~3 main use cases of the proposed feature Enable users to insert videos into pages

what types of users can benefit from using your proposed feature Users who use videos to express ideas

Reference:

MrHeer commented 2 years ago

Can I take it?

LucasXu0 commented 2 years ago

Sure. I assigned this issue to you.

MrHeer commented 2 years ago

Is there a more detailed requirements document and UI?

LucasXu0 commented 2 years ago

At present, there is no perfect design draft. You can refer to the design of the image plugin, and support functionalities such as scaling, aligning, copying, deleting, etc.

MrHeer commented 2 years ago

Hi, I have no idea about video player. Do you have some suggestion? Should I develop a Flutter plugin?

LucasXu0 commented 2 years ago

Hi, @MrHeer. You don't need to make a Flutter plugin. Here is the guiding document. customizing-a-component. Feel free to request more information if you have any questions after reading it.

MrHeer commented 2 years ago

But there should have a VideoNodeWidget like the ImageNodeWidget in example, In the example, use a Image.network to display a Image, but there are no weiget to render a video player.

LucasXu0 commented 2 years ago

After doing a simple investigation, I haven't found such a widget to render video for the time being. Perhaps this feature can be suspended first.

MrHeer commented 2 years ago

Can I create a draft PR to waiting the video widget?

LucasXu0 commented 2 years ago

Yup. I will keep looking for a cross-platform video player. (Web, Mobile and Desktop)

ishtiaqshaheer commented 1 year ago

Hi, is adding video player within editor available or ready yet?

LucasXu0 commented 1 year ago

Bump it up. Finally, there's a package that supports all platforms(not verified yet.).

MrHeer commented 1 year ago

I have a lot of time to continue to complete this task.

stickyfran commented 2 months ago

Plz :( This and having thumbnail for uploaded videos