search

AppFlowy-IO / AppFlowy

Bring projects, wikis, and teams together with AI. AppFlowy is an AI collaborative workspace where you achieve more without losing control of your data. The best open source alternative to Notion.
https://www.appflowy.io
GNU Affero General Public License v3.0
57.13k stars 3.75k forks source link

[FR] Report binary size in CI action #1280

Open LucasXu0 opened 2 years ago

LucasXu0 commented 2 years ago

Description

Binary size is an important metric for us, and it is easy to overlook. It would be nice if we had some sort of GitHub integration (a bot or action or app) that would automatically do a release build of a new PR, and report the difference in binary size between that PR and the current main branch.

Impact

Let us focus on the app size easily.

Additional Context

This implementation should include:

LucasXu0 commented 2 years ago

An illustrative example shows we need this function. https://github.com/AppFlowy-IO/AppFlowy/issues/1279

yashgosa commented 1 year ago

@LucasXu0 @annieappflowy I would love to work on this issue pls assign it to me

LucasXu0 commented 1 year ago

Hey, @yashgosa. I assigned it to you.

Xazin commented 1 year ago

Hey @yashgosa, how are you doing?

If you need help with this issue you can reach out to me on discord.

yashgosa commented 1 year ago

Hey sorry I completely forgot about this issue I will make a PR by Sunday :)

AnsahMohammad commented 8 months ago

In the release.yml, I noticed that we're building binaries for various platforms. How do you suggest configuring threshold X? Will it be consistent across all OS binaries, or will it vary? Additionally, should it be hard-coded, or do we plan to utilize GitHub secrets?

I'm thinking of using artifacts to record binary sizes and make it easier to compare to following PRs.