Closed a-wallen closed 1 year ago
I have reproduced this bug, and would like this task to be assigned to me.
just checked and the bug doesn't only exist with boards but with grids as well
@DestinedCodes, thank you!
I just began working on it. I'll keep this space posted on my progress. I am applying for octernship, so an issue with the label "good first issue for devs" would be great.πππ
I suspect the answer is in built_in_page_widget.dart
@override
Widget build(BuildContext context) {
return FutureBuilder<dartz.Either<ViewPB, FlowyError>>(
builder: (context, snapshot) {
if (snapshot.hasData) {
final board = snapshot.data?.getLeftOrNull<ViewPB>();
if (board != null) {
return _build(context, board);
}
}
return const Center(
child: CircularProgressIndicator(),
);
},
future: AppBackendService().getView(appID, gridID),
);
}
I have fixed the bug. please reviewπ. It was interesting working on this, but it wasn't really easy to build the app on my laptop. (I had to do more debugging on my laptop than I had to fix the code π)
Fixed
Bug Description
If you add a referenced board to a page and delete the board, the page will have a permanent circular progress indicator.
How to Reproduce
Expected Behavior
The referenced board should not show.
Operating System
Windows 10
AppFlowy Version(s)
main
Screenshots
Additional Context
No response