search

AppFlowy-IO / AppFlowy

Bring projects, wikis, and teams together with AI. AppFlowy is an AI collaborative workspace where you achieve more without losing control of your data. The best open source alternative to Notion.
https://www.appflowy.io
GNU Affero General Public License v3.0
57.48k stars 3.77k forks source link

[Bug] Upon deleting Grid, Board or Calendar from the sidebar, no banner to restore or delete permanently appears. #3471

Open MayurSMahajan opened 1 year ago

MayurSMahajan commented 1 year ago

Bug Description

When you delete a document in AppFlowy you see a dialog appear at the top of your document: image

No such dialog appears when you delete a Grid, Board or Calendar. Since there is no indicator of the file being deleted, the user may continue editing the Grid/Board/Calendar without noticing that they have deleted it.

This is how it appears:

https://github.com/AppFlowy-IO/AppFlowy/assets/47064215/908507cb-8010-4a6e-a758-578818738c00

How to Reproduce

  1. Open AppFlowy
  2. Create a new Grid/Board/Calendar
  3. Delete the newly created item from the sidebar
  4. Observe how the deleted item still appears without any indicator of it being deleted.
  5. Observe how you can still change the deleted item's content.

Expected Behavior

Some indication that the Grid/Board/Calendar is deleted and thus should not be modified.

Operating System

Windows 11

AppFlowy Version(s)

1.0.0

Screenshots

Refer to the video attached above.

Additional Context

No response

Azanul commented 1 year ago

May I take this up?

richardshiue commented 1 year ago

Assigned @Azanul, have fun!

0xJaskeerat commented 1 year ago

Hey @MayurSMahajan @richardshiue , Can I try my hands on this , if @Azanul is not able to do

MayurSMahajan commented 1 year ago

@Azanul are you still working on this?

Azanul commented 1 year ago

@Azanul are you still working on this?

Yes. I haven't used block before that's why I'm taking some time, but I'll raise the PR in a couple of days.

SharmaDhruv2511 commented 1 year ago

is this issue still open?? want to contribute to it??

MayurSMahajan commented 1 year ago

@Azanul's PR is being review, look for other issues.

SharmaDhruv2511 commented 1 year ago

is this issue still open??

Xazin commented 1 year ago

is this issue still open??

There is an open PR for this, thus it's not closed yet, but work are done/in progress.