Closed LucasXu0 closed 5 months ago
Attention: Patch coverage is 91.89189%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 74.79%. Comparing base (
d6388a4
) to head (8c448ce
).
Files | Patch % | Lines |
---|---|---|
.../block_component/rich_text/appflowy_rich_text.dart | 91.89% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
There's a breaking change in Flutter 3.22.x
The
getFullHeightForCaret
didn't respect the font size anymore if it's in the sub levelFlutter 3.19.0
https://github.com/AppFlowy-IO/appflowy-editor/assets/11863087/8892bcba-fa02-4c38-8546-e2442ac0dea7
Flutter 3.22.0
https://github.com/AppFlowy-IO/appflowy-editor/assets/11863087/86871f04-1baf-4dcb-a7a2-e226d3561574
Now
https://github.com/AppFlowy-IO/appflowy-editor/assets/11863087/b98255e0-b433-4c53-a9e2-d64da1fd0218
workaournd:
get the maximum line height and font size from sub textspans and set them to the parent textspan
closes https://github.com/AppFlowy-IO/appflowy-editor/issues/819