AppFlowy-IO / appflowy-editor

A highly customizable rich-text editor for Flutter. The AppFlowy Editor project for AppFlowy and beyond.
https://pub.dev/packages/appflowy_editor
Other
448 stars 188 forks source link

Uses PlatformExtension to more safely detect platform on web #853

Closed dmosdallas closed 2 months ago

dmosdallas commented 2 months ago

Standard Platform.isXOS lookups fail on web and need to be gated with a kIsWeb check. There's a PlatformExtension class that does exactly that. This change migrates some lines that I got exceptions on to the safer path that checks kIsWeb.

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.