AppFlowy-IO / appflowy-editor

A highly customizable rich-text editor for Flutter. The AppFlowy Editor project for AppFlowy and beyond.
https://pub.dev/packages/appflowy_editor
Other
462 stars 197 forks source link

[Bug] MobileToolbarV2 shows unnecessary space when keyboard is out #959

Open saif-ellafi opened 2 hours ago

saif-ellafi commented 2 hours ago

Bug Description

Not sure if I am doing anything wrong, but there is a padding space of proportional size to toolbarHeight when the keyboard is up. This happens to be inside the Widget Column inside MobileToolbarV2

image

image

How to Reproduce

Follow the MobileToolbarV2 example and try on a mobile phone. When the keyboard is up, a large padding area shows at the bottom inside MobileToolbarV2

Expected Behavior

The extra space is not necessary

Operating System

Android

AppFlowy Editor Version(s)

4.0.0

Screenshots

No response

Additional Context

No response

saif-ellafi commented 2 hours ago

@LucasXu0 - I think the ValueListenableBuilder on Keyboard being shown is not needed on MobileToolbarV2 as per in the screenshot, the toolbar is alwalys on top of the keyboard, or at least it can be managed by the rest of the app.