search

AppHouseKitchen / AlDente-Charge-Limiter

macOS menubar tool to set Charge Limits and prolong battery lifespan
https://apphousekitchen.com/
Other
7.63k stars 286 forks source link

"Stop charging when sleeping" prevents charge to a sleeping macbook, even if significantly below the charge limit #1132

Closed joshjud closed 5 months ago

joshjud commented 6 months ago

Describe the bug "Stop charging when sleeping" prevents charge to a sleeping macbook that is below the charge limit.

To Reproduce Let charge fall below charge limit. Close macbook and let it go to sleep. Connect power. Macbook will not charge unless lid is opened.

Expected behavior AlDente should wake macbook to check charge limit when power adapter is connected even if "Stop charging when sleeping" is enabled. This will allow the macbook to charge till the charge limit, after which AlDente can let the macbook go back to sleep.

MatthiasKerbl commented 6 months ago

Hi @mojoba,

The setting "Stop charging when sleeping" does exactly what it says, it stops charging when the MacBook is asleep even if it gets plugged in while it is asleep. If you want your MacBook to charge to the charge limit while the lid is closed or while it would otherwise be asleep, you need to activate the feature "Disable Sleep until Charge Limit".

Best, Matthias

joshjud commented 6 months ago

Hi Matthias,

The setting indeed does what it says, however if the setting is disabled then, as the app states, the charge may no longer be limited by the app.

I’m not sure what the solution is since, as the documentation states, the app cannot limit the charge while the MacBook is asleep anyway.

Is there a wake signal the app can produce to periodically check the charge?

On Mon, Dec 18, 2023 at 3:07 AM Matthias Kerbl @.***> wrote:

Hi @mojoba https://github.com/mojoba,

The setting "Stop charging when sleeping" does exactly what it says, it stops charging when the MacBook is asleep even if it gets plugged in while it is asleep. If you want your MacBook to charge to the charge limit while the lid is closed or while it would otherwise be asleep, you need to activate the feature "Disable Sleep until Charge Limit".

Best, Matthias

— Reply to this email directly, view it on GitHub https://github.com/AppHouseKitchen/AlDente-Charge-Limiter/issues/1132#issuecomment-1859852082, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW6ARRPKMR5KS7SUQJJ2AJDYKABTRAVCNFSM6AAAAABAYC6NR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZHA2TEMBYGI . You are receiving this because you were mentioned.Message ID: @.***>

MatthiasKerbl commented 6 months ago

Hi @mojoba,

Is there a wake signal the app can produce to periodically check the charge?

No, macOS does not allow third-party apps to wake up the MacBook.

Which behavior would you like to have?

Best, Matthias

MatthiasKerbl commented 5 months ago

Hi @mojoba,

It's been a while since we last heard from you, so I'm gonna go ahead and close this issue for now. If you need to come back to it later, just let me know. I'm here to help and can easily reopen it for you.

Best, Matthias