AppHouseKitchen / AlDente-Charge-Limiter

macOS menubar tool to set Charge Limits and prolong battery lifespan
https://apphousekitchen.com/
Other
7.63k stars 286 forks source link

Dismissing pop-up unreliable when clicking _above_ the icon in the menu bar #1158

Open miallo opened 5 months ago

miallo commented 5 months ago

Describe the bug When clicking on the icon in the menu bar I expect it to toggle the menu and so to close it. That also works reliably when clicking inside of the area that gets highlighted when holding down, but you can also trigger the menu with the cursor at the very top of the screen, but that will be very unreliable and most of the times just flicker for a split second and keep the menu open. (Same for below the active field, but inside of the menu bar)

To Reproduce Steps to reproduce the behavior:

  1. Clicking above the icon the menu-bar should toggle the menu

Expected behavior Instead of toggling the menu, it (most of the times) will only open the menu and when trying to close it, it flickers instead. Clicking on the icon area itself works as expected.

Screenshots https://github.com/AppHouseKitchen/AlDente-Charge-Limiter/assets/6929993/fbb4901e-9573-46e6-b226-01ef2db33527

MacBook (please complete the following information):

Additional context I could not find a reason why sometimes it seems to work to toggle and then again without moving the mouse it does not...

Maybe related to #984 in that it could be because it uses a custom container (It is only a guess, but with the default components I would expect the behaviour to work out of the box)

MatthiasKerbl commented 5 months ago

Hi @miallo,

Thank you for the detailed bug report and interesting observation which I haven't noticed before. We will look into it and try to improve it with one of the upcoming updates.

Best, Matthias