search

AppHouseKitchen / AlDente-Charge-Limiter

Menubar Tool to set Charge Limits and Prolong Battery Lifespan
https://apphousekitchen.com/
Other
7.96k stars 293 forks source link

Hardware Battery Percentage: 79.51% != 80% #678

Open Volodymyr-13 opened 2 years ago

Volodymyr-13 commented 2 years ago

Describe the bug Rounding in Hardware Battery Percentage mode.

To Reproduce Steps to reproduce the behavior:

  1. Set Hardware Battery Percentage mode ON.
  2. Set Charge Limit to 80%
  3. Start charging.
  4. Notice that charging stopped at actual 79.51%(data from Wattagio)

Expected behavior Battery charging should stop more closely to 80%. In real life, It will not be exactly 80.00%, but easily can be 80.1% or even 80.05%, which is more close to set value of 80%.

Screenshots

Screen Shot

MacBook (please complete the following information):

Screen Shot 2
andrewcrook commented 2 years ago

What’s the difference between MacOS's battery reading and the Hardware Battery Percentage mode from Al dente?

MatthiasKerbl commented 2 years ago

Describe the bug Rounding in Hardware Battery Percentage mode.

To Reproduce Steps to reproduce the behavior:

  1. Set Hardware Battery Percentage mode ON.
  2. Set Charge Limit to 80%
  3. Start charging.
  4. Notice that charging stopped at actual 79.51%(data from Wattagio)

Expected behavior Battery charging should stop more closely to 80%. In real life, It will not be exactly 80.00%, but easily can be 80.1% or even 80.05%, which is more close to set value of 80%.

Screenshots

Screen Shot

MacBook (please complete the following information):

  • MacBook Pro M1 2021
  • macOS 12.3
  • AlDente Pro
  • AlDente Version 1.17
  • List of all enabled/disabled settings in AlDente:
Screen Shot 2

Hi @KAMIKAZEUA,

I think for most features and goals of AlDente it is already accurate enough. However, I also understand where your point of view is coming from and maybe we can do something about it. I will put it on our list of potential future improvements but other things are more important currently.

Cheers, Matthias

MatthiasKerbl commented 2 years ago

What’s the difference between MacOS's battery reading and the Hardware Battery Percentage mode from Al dente?

Hi @andrewcrook,

I tried to explain this in more detail in this blog post: https://apphousekitchen.com/feature-explanation-hardware-battery-percentage/

Cheers, Matthias

andrewcrook commented 2 years ago

I tried to explain this in more detail in this blog post: https://apphousekitchen.com/feature-explanation-hardware-battery-percentage/

@MatthiasKerbl

Sorry what I was hinting at was if the discrepancy was between hardware reports and macOS reported. Because I have roughly 5% difference but that is down to degradation with my battery health being around 93.2%

But yeah it looks like its rounding in this case.

Bachsau commented 2 years ago

It is in the range of measurement errors. There is no way to exactly measure the charging state of a battery. Percentage values always involve a lot of guesswork and mathematics. That's why we have calibration.

andrewcrook commented 2 years ago

actually pays to recharge around different levels

Volodymyr-13 commented 1 year ago

@MatthiasKerbl can you finally implement such a simple feature? I want your app show % like a Wattagio doing, like more PRO way! Something like 79.86% or 80.01%, but not just 80% pls, thats not for pro's This is pretty simple, just don't round it that it..

Screenshot

Screenshot 1

Volodymyr-13 commented 7 months ago

@MatthiasKerbl any updates on this?

Screenshot 1

Screenshot

Just never enabled show % for AlDente bcs it's just non informative at all.

MatthiasKerbl commented 7 months ago

Hi @Volodymyr-13,

As mentioned before, in our opinion changing the percentage from full percent to a hundredth of a percent does mainly add noise due to the state of charge value always being a good guess and not accurate to a hundredth of a percent. Therefore, we have no plans at the moment to change this.

Hope you understand.

Best, Matthias

Volodymyr-13 commented 7 months ago

@MatthiasKerbl pls tell me why other apps does this and have option for this, but your app don't? Adds noise or something - this is up to me to decide, when I enable "Show More Accurately" option, thats it, but it should be given to me anyway, specially bcs it's easy to implement.

I think just your main idea overall - you don't want to fill UI with some new checkboxes and fighting with just this, but not listening for requests. But thats simple just add another tab: "Advanced" and put all such advanced settings into it. Sounds good?

MatthiasKerbl commented 7 months ago

@MatthiasKerbl pls tell me why other apps does this and have option for this, but your app don't? Adds noise or something - this is up to me to decide, when I enable "Show More Accurately" option, thats it, but it should be given to me anyway, specially bcs it's easy to implement.

I think just your main idea overall - you don't want to fill UI with some new checkboxes and fighting with just this, but not listening for requests. But thats simple just add another tab: "Advanced" and put all such advanced settings into it. Sounds good?

Hi @Volodymyr-13,

Thanks again for your feedback and we are considering your input for future developments. We are always trying to think in first principles when updating or developing a new feature and not just copying others. Good point with the advanced setting. However, it is just not always so simple. There is so much more to consider than what meets the eye such as development time/effort/cost, bug potential, edge-case scenarios, documentation, purpose, consistency, convenience, simplicity, compatibility with macOS versions/MacBook models/chargers/docks/monitors, and more. Your suggested percentage update for example, we are currently supporting 46 different MacBook models and many of them don't even have the option to show the percentage to a hundredth of a percent.

I hope this makes it easier to understand some of our decisions.

Best, Matthias