search

AppHubPlatform / apphub

apphub is an iOS client for AppHub
https://apphub.io
Other
206 stars 29 forks source link

Crash related to RCTNativeAppEventEmitter #22

Closed geldarhb closed 8 years ago

geldarhb commented 8 years ago

Hey,

When my users open the app and there's an update pending, I get a crash that's originated in the sendAppEventWithName call in your AppHubReactModule code. I read a bit about it and it seems like others also experience some crashes when using sendAppEventWithName instead of sendDeviceEventWithName.

Do you know smtng about it? Or alternatively on the crash I've described.

Thanks, Guy

drtangible commented 8 years ago

@geldarhb I ran into this and was able to work around the issue by importing NativeAppEventEmitter in my app.

// index.ios.js
import React from 'react-native';
const { NativeAppEventEmitter } = React;

I briefly tested again after https://github.com/AppHubPlatform/apphub-ios/pull/19 landed, as I thought that may have been related, but appeared to be running into the same issue w/o importing that module.

geldarhb commented 8 years ago

@drtangible thanks for the quick response here! I'll give it a try! I replaced sendAppEventWithName with sendDeviceEventWithName and now everything works. The problem is that I'm not sure what's the difference between the two... :/

arbesfeld commented 8 years ago

@geldarhb What version of the AppHub SDK are you running? I believe that this should have been fixed in #19 (released in 0.5.0), but the workaround that @drtangible mentioned fixes previous versions of the SDK.