AppHubPlatform / apphub

apphub is an iOS client for AppHub
https://apphub.io
Other
206 stars 29 forks source link

Use React/Core for the podspec dependency #32

Closed orta closed 8 years ago

orta commented 8 years ago

Hey there! Nice library, looking 👍 so far :)

So, you have a dependency on React however, the only headers that you use are these:

screen shot 2016-09-05 at 3 10 00 pm

Which are all available in just React/Core ( this is a CocoaPods subspec feature the allows you to reduce your dependency tree )

screen shot 2016-09-05 at 3 11 45 pm

arbesfeld commented 8 years ago

This sounds good! Will this will also require a bump in the podspec version?

orta commented 8 years ago

I figure you'd do that the next time you deploy, in the mean-time anyone can use:

  pod 'AppHub', :git => "https://github.com/AppHubPlatform/apphub.git"

To get this. Mainly, because I imagine you'd keep it in-step with the package.json and I don't want to make them mis-matched.

arbesfeld commented 8 years ago

Perfect, thanks @orta!