AppImage / AppImageSpec

This repository holds the specification for the AppImage format.
http://appimage.org/
MIT License
71 stars 22 forks source link

Name of desktop file in appdir root SHOULD match? #17

Open kossebau opened 5 years ago

kossebau commented 5 years ago

The current section about "filesystem image" has this recommendation for the name of the desktop file in the root dir:

  • SHOULD contain exactly one $APPNAME.desktop file in its root directory with $APPNAME being the name of the payload application

This conflicts slightly with the fact that for existing applications which follow latest xdg recommendations the desktop file names these days have tld-prefixes (e.g. "org.kde.kdevelop.desktop", "org.kde.krita.desktop", "org.qt-project.qtcreator.desktop").

Also does it not match the AppDir specification at docs.appimage.org where it says:

The name of the file doesn’t matter, as long as it carries the .desktop extension.

The latter is reflected also by code like from the appimagetool which picks up whatever first desktop file there is gchar *desktop_file = find_first_matching_file_nonrecursive(source, "*.desktop");

So please sync the specs and extend it with some examples of applications that normally have a desktop file with a tld-prefixed name. That should help developers manually compiling appdir content to know what names are fine to use.

TheAssassin commented 5 years ago

I think we should change the AppImage spec to reflect the current situation instead of increasing the number of constraints in appimagetool. I don't think more strict rules here have any positive effect, they might even break existing third-party tools. The "AppDir spec" is more precise, and I think we should use it to adjust the AppImage spec. (Of course, the AppImage spec is always the top priority document which we rely on, but it should be correct.)

probonopd commented 5 years ago

When I wrote the spec I meant to re-use what was already out there, with as little additional "glue" added as we could get away with: