search

AppImage / appimage.github.io

Given an URL to an AppImage, the GitHub action in this project inspects the AppImage and puts it into a community-maintained catalog
https://appimage.github.io/
Other
295 stars 545 forks source link

Magic number not detected #135

Open probonopd opened 6 years ago

probonopd commented 6 years ago

Magic number not detected.

This is blocking

probonopd commented 6 years ago

@Develar do you have any idea why newer AppImages apparently lack the magic bytes? Has anything in electron-builder recently changed when it comes to how the AppImage is generated?

develar commented 6 years ago

electron-builder appends custom data to the end of file, but header of file is not modified (and original appimagetool is used to generate). I will investigate issue a little bit later.

probonopd commented 6 years ago

Very likely related to https://github.com/AppImage/AppImageKit/issues/521

probonopd commented 6 years ago

Most likely fixed in 031365d - turns out running strip on the runtime had inadvertently removed the magic bytes. @develar please retry with the latest continuous build.

probonopd commented 6 years ago

https://github.com/electron-userland/electron-builder-binaries/issues/6

probonopd commented 6 years ago

If your application is hit by this issue, the solution is easy: Please update electron-builder to the latest version so that the generated AppImage gets the correct magic bytes.

To verify, run xxd Some.AppImage | head -n 1 - it must show the AppImage type-2 magic bytes 0x414902:

Reference: