AppImage / appimage.github.io

Given an URL to an AppImage, the GitHub action in this project inspects the AppImage and puts it into a community-maintained catalog
https://appimage.github.io/
Other
295 stars 543 forks source link

Check handling of svgz icons // QTox missing App Icon #1498

Open cadamsdev opened 5 years ago

cadamsdev commented 5 years ago

https://appimage.github.io/qTox/

If icon doesn't exist can we set "icons" to null?

` { "name": "qTox",

    "description": "Qt 5 based Tox instant messenger for secure communication",

    "categories": ["Network"],
    "authors" : [{"name":"qTox","url":"https://github.com/qTox"}],
    "license" : "GPL-3.0",
    "links": [{"type":"GitHub","url":"qTox/qTox"},{"type":"Download","url":"https://github.com/qTox/qTox/releases"}],
    "icons": ["qTox/icons/scalable/qtox.svgz"],
    "screenshots" : ["qTox/screenshot.png"]
    }`

Should be this icon

https://avatars0.githubusercontent.com/u/9519241?s=200&v=4

taken from https://github.com/qTox

probonopd commented 5 years ago

It does seem to get extracted: https://github.com/AppImage/appimage.github.io/tree/master/database/qTox/icons/scalable

It also does seem to get served: https://gitcdn.xyz/cdn/AppImage/appimage.github.io/b714f2b4ee4e4a92a1ddc318557b37f4436d1371/database/qTox/icons/scalable/qtox.svgz

It also does seem to be valid:

me@host:~$ file qtox.svgz 
qtox.svgz: gzip compressed data, last modified: Fri Jul 20 23:21:11 2018, from Unix

me@host:~$ cp qtox.svgz qtox.svg.gz

me@host:~$ gunzip qtox.svg.gz 

me@host:~$ file qtox.svg
qtox.svg: SVG Scalable Vector Graphics image

Maybe some systems can't handle svgz files?

cadamsdev commented 5 years ago

@probonopd I would just convert it to a PNG.

Flathub uses a png for this app https://flathub.org/repo/appstream/x86_64/icons/128x128/io.github.qtox.qTox.png

https://flathub.org/repo/appstream/x86_64/icons/128x128/io.github.qtox.qTox.png

https://caniuse.com/#search=png

probonopd commented 5 years ago

Thanks @chadalen but we are using only what comes inside the AppImage, in order to make maintaining this directory fully automated. We are not adding files to this directory that cannot be extracted from the AppImage itself.

So one option would be to convert any svgz icons that we can extract from the AppImage to svg...

probonopd commented 3 years ago

It's best practice to use png icons inside the AppImage to prevent errors like this.