Open cadamsdev opened 5 years ago
It does seem to get extracted: https://github.com/AppImage/appimage.github.io/tree/master/database/qTox/icons/scalable
It also does seem to get served: https://gitcdn.xyz/cdn/AppImage/appimage.github.io/b714f2b4ee4e4a92a1ddc318557b37f4436d1371/database/qTox/icons/scalable/qtox.svgz
It also does seem to be valid:
me@host:~$ file qtox.svgz
qtox.svgz: gzip compressed data, last modified: Fri Jul 20 23:21:11 2018, from Unix
me@host:~$ cp qtox.svgz qtox.svg.gz
me@host:~$ gunzip qtox.svg.gz
me@host:~$ file qtox.svg
qtox.svg: SVG Scalable Vector Graphics image
Maybe some systems can't handle svgz files?
@probonopd I would just convert it to a PNG.
Flathub uses a png for this app https://flathub.org/repo/appstream/x86_64/icons/128x128/io.github.qtox.qTox.png
Thanks @chadalen but we are using only what comes inside the AppImage, in order to make maintaining this directory fully automated. We are not adding files to this directory that cannot be extracted from the AppImage itself.
So one option would be to convert any svgz icons that we can extract from the AppImage to svg...
It's best practice to use png icons inside the AppImage to prevent errors like this.
https://appimage.github.io/qTox/
If icon doesn't exist can we set "icons" to null?
` { "name": "qTox",
Should be this icon
taken from https://github.com/qTox