search

AppImage / type2-runtime

The runtime is the executable part of every AppImage. It mounts the payload via FUSE and executes the entrypoint.
Other
22 stars 17 forks source link

Trigger appimagetool build #50

Closed probonopd closed 2 months ago

probonopd commented 2 months ago

Try to trigger an appimagetool build in addition to uploading the continuous build to GitHub Releases.

Thus, when a change in this repository prevents the appimagetool AppImage from being built correctly, we will know immediately rather than a few months down the line.

This in part might have prevented

from having happened unnoticed.

probonopd commented 2 months ago

TypeError: Cannot read properties of undefined (reading 'token')

How to do this correctly?

TheAssassin commented 2 months ago

We've talked about this recently and I absolutely hate the idea. Plus, the token you try to use isn't even authorized to do so.

appimagetool automatically downloads the latest runtime anyway.

TheAssassin commented 2 months ago

P.S.: If testing is your intention, you can clone appimagetool's repository here, too, and run the build script accordingly.

probonopd commented 2 months ago

We've talked about this recently and I absolutely hate the idea.

Can you remind me of why you don't like this? Maybe combining the repos of type2-runtime and appimagetool would be a more elegant solution then?

appimagetool automatically downloads the latest runtime anyway.

Which is what I still think is too fragile, especially when the two are not in sync (which can happen due to developer error or simply because the user uses an older appimagetool version...)

TheAssassin commented 2 months ago

Maybe combining the repos of type2-runtime and appimagetool would be a more elegant solution then?

Yet again, discussed and rejected. That's what we had, and it's what we never want to go back to.

TheAssassin commented 2 months ago

You should open an issue by the way.

probonopd commented 2 months ago

You should open an issue by the way.

Open an issue for what? Everything I propose doesn't seem to be liked by you (triggering builds in another repo automatically, merging repos). For bundling the runtime in the linuxdeployqt AppImage there is already an issue open,

TheAssassin commented 2 months ago

The issue here is that this discussion is likely going to be lost in a closed PR.

Everything I propose doesn't seem to be liked by you

We've discussed every single option and I've always had the better arguments after all. It's tiring to reiterate over each of them every time some issue surfaces. It's nothing I'd do in a project because it's not productive.

It seems that the issue here is missing documentation from meetings we had...