appimageupdatetool removes the wrong file

[Samueru-sama]

Context

We are testing to integrate appimageupdatetool into AM, it only happens when we give a relative instead of a full path, it deletes the updated appimage and leaves the *.zs-old file.

[TheAssassin]

Please provide logs etc.

[Samueru-sama]

Please provide logs etc.

From the linked comment:

~/Local/opt/brave/ ./AM-updater                                                                              2313ms 
Checking for updates...
Fetching release information for tag "stable" from GitHub API.
Fetching release information for tag "stable" from GitHub API.
zsync2: Using CA bundle found on system: /etc/ssl/cert.pem
... done!
Starting update...

Fetching release information for tag "stable" from GitHub API.
0% done
Updating from GitHub Releases via ZSync
Fetching release information for tag "stable" from GitHub API.
zsync2: Using CA bundle found on system: /etc/ssl/cert.pem
0% done
zsync2: /home/samuel/Local/opt/brave/./brave found, using as seed file
zsync2: Target file: /home/samuel/Local/opt/brave/./brave
zsync2: Reading seed file: /home/samuel/Local/opt/brave/./brave
5.27% done (7.79 of 147.71 MiB)...
zsync2: Usable data from seed files: 5.273040%
zsync2: Renaming temp file
zsync2: Fetching remaining blocks
5.27% done (7.79 of 147.71 MiB)...
zsync2: Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/321930328/f2885778-c984-4c24-80e0-89115ad655b2?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=releaseassetproduction%2F20240818%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240818T105710Z&X-Amz-Expires=300&X-Amz-Signature=aa9118e2a5faa04592467fe821434abaeecdf85fa38e013de1490dcd0acb85cb&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=321930328&response-content-disposition=attachment%3B%20filename%3DBrave-stable-v1.69.147-x86_64.AppImage&response-content-type=application%2Foctet-stream
zsync2: optimized ranges, old requests count 247, new requests count 6

96.95% done (143.21 of 147.71 MiB)...
zsync2: Verifying downloaded file
100.00% done (147.71 of 147.71 MiB)...
zsync2: checksum matches OK
zsync2: used 8167424 local, fetched 151826832
100.00% done (147.71 of 147.71 MiB)...
Validation warning: AppImage not signed
Removing old AppImage: /home/samuel/Local/opt/brave/brave
Update successful. Updated existing file /home/samuel/Local/opt/brave/./brave
chmod: cannot access './brave': No such file or directory

notice the Removing old AppImage: /home/samuel/Local/opt/brave/brave

The AM-updater calls appimageupdatetool this way:

APP=brave
version="$SITE2"
if command -v appimageupdatetool >/dev/null 2>&1; then
    cd "/home/samuel/Local/opt/$APP" || exit 1
    appimageupdatetool -Or ./"$APP" && chmod a+x ./"$APP" && echo "$version" > ./version && exit 0
fi

It only happens when I give it the relative path to appimageupdatetool, it doesn't happen if I give it the full path.

Let me know if I need to provide more info, I don't know if there is a debug mode for appimageupdatetool.