search

AppImageCommunity / appimaged

appimaged is a daemon that monitors the system and integrates AppImages.
https://appimage.org
Other
296 stars 16 forks source link

Icon gets shown in menu but not in file thumbnail; why? #28

Open probonopd opened 5 years ago

probonopd commented 5 years ago

Icon for Jitsi Meet gets shown in menu but not in file thumbnail; why?

XFCE on Clear Linux OS with the latest appimaged

$ /home/user/.local/bin/appimaged --version
appimaged, continuous build (commit 189b800), build 42 built on 2018-09-06 19:33:24 UTC

jitsi

TheAssassin commented 5 years ago

That file must be run at least once to create the thumbnail. Did you run it?

probonopd commented 5 years ago

I have appimaged installed and I assume it creates the thumbnails? No?

TheAssassin commented 5 years ago

Not sure whether it does. You should check your source code... I only know for sure that thumbnails are created by the runtime on execution.

probonopd commented 5 years ago

But no, also after running it there is still no thumbnail.

probonopd commented 5 years ago

The inside of the AppImage looks immaculate:

user@clr-b8cf94b408544d1a88c7b8ad7ecfb2cf ~ $ find /tmp/.mount_jitsi-SDKBVq/ | grep .png$
/tmp/.mount_jitsi-SDKBVq/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/128x128/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/16x16/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/24x24/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/256x256/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/32x32/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/48x48/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/512x512/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/64x64/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/96x96/apps/jitsi-meet.png
user@clr-b8cf94b408544d1a88c7b8ad7ecfb2cf ~ $ grep -r Icon= /tmp/.mount_jitsi-SDKBVq/jitsi-meet.desktop 
Icon=jitsi-meet
TheAssassin commented 5 years ago

The thumbnail is created from the .DirIcon.

probonopd commented 5 years ago

...which is missing indeed:

user@clr-b8cf94b408544d1a88c7b8ad7ecfb2cf ~ $ find /tmp/.mount_jitsi-SDKBVq/ | grep DirIcon
(nothing)

Bug in electron-builder?

TheAssassin commented 5 years ago

They violate the AppDir specification (which someone renamed for some reason ... ... ...).

It's a specification! And only if you call it that way, people will adhere to it!

TheAssassin commented 5 years ago

Also, don't rename references in Sphinx without doing it anywhere. Now, we have broken references...

probonopd commented 5 years ago

Ouch! What is the proper way to edit this? Remember, my level of sophistication is editing .md

probonopd commented 5 years ago

One could see it as:

TheAssassin commented 5 years ago

Only what we don't own the AppDir specification, as it's a specification from the ROX filer people.

I reverted the commit with the following description:

    Revert ""description", not "specification""

    We **extended** the AppDir format. If you like OOP terms, we inherit
    the AppDir specification, and extend it.

    Also, references must not be renamed in a single file only (especially
    not the declaration), otherwise things will break.

It is our specification, as we add additional rules to it. So it is our specification, even if the text is not in RFC style.

TheAssassin commented 5 years ago

Remember, my level of sophistication is editing .md

There is no difference whether to do it in .md or .rst (only that Markdown doesn't have real references). If you rename a heading in Markdown, but don't apply the change in all files that link to it, links will break. That's why many links in Wikis are broken (like in the old AppImageKit wiki).

The proper way is to do it using sed. But in terms of ReST, there is no real reason to rename references. Their internal identifiers only, links will rename automatically unless they have a custom title anyway.

The Travis CI build perfoms a link check that identifies such problems. But ideally, you do it by building locally, and applying a link change before committing. (I know that's not so much your style, hence the Travis build.)

TheAssassin commented 5 years ago

By the way, see https://docs.appimage.org/reference/appdir.html#history for a description why we call it specification. We do of course credit ROX filer.