AppImageCommunity / libappimage

Implements functionality for dealing with AppImage files
https://appimage.org
Other
46 stars 29 forks source link

ERROR: appimage_get_type : Unknown AppImage format #102

Closed probonopd closed 5 years ago

probonopd commented 5 years ago

Getting lots of

ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format
ERROR: appimage_get_type : Unknown AppImage format

It would be useful if the filename was printed too, to make some sense of the output.

appimaged, continuous build (commit 2e34378), build 108 built on 2019-03-14 17:43:20 UTC
probonopd commented 5 years ago

We can now see which files are "Unknown AppImage format". Basically all files that are not AppImages, of which I have a lot in my (sub)directories (next to AppImages). For example:

ERROR: appimage_get_type : Unknown AppImage format: /isodevice/Applications/Firefox-64.0.glibc2.3.4-x86_64.AppImage.home/.cache/mozilla/firefox/zc7vuyd1.default/cache2/entries/6F8C87BA59FD179566B173D253966BD1F181CAE4

Of course this is not an AppImage file.

Hence, a file that is not an AppImage should not throw an error or be reported on the command line (unless in special debugging mode).

https://github.com/AppImage/libappimage/blob/f3d6400ce1c33b96e8671a971ebcb0df4a63faed/src/libappimage/core/AppImage.cpp#L44

azubieta commented 5 years ago

should be fixed by #112

probonopd commented 5 years ago

Still getting this

me@host:~$ '/home/me/Downloads/appimaged-x86_64.AppImage' --version
+appimaged, continuous build (commit 334ff48), build 143 built on 2019-05-10 05:55:51 UTC
(...)
ERROR: appimage_register_in_system : boost::filesystem::permissions: Operation not permitted: "/isodevice/Applications/Kdenlive-x86_64.AppImage"
ERROR: appimage_register_in_system : Unexpected char '_' at 0
ERROR: appimage_register_in_system : boost::filesystem::permissions: Operation not permitted: "/isodevice/Applications/k3b-git20170204-x86_64.AppImage"
ERROR: appimage_get_type : Unknown AppImage format: /isodevice/Applications/Slic3rPEProfiles/print/sp 0.45mm FAST 0.6 nozzle.ini
ERROR: appimage_get_type : Unknown AppImage format: /isodevice/Applications/Slic3rPEProfiles/print/sp 0.35mm FAST 0.6 nozzle.ini

Please always confirm using a continuous appimaged build from Travis CI build that the changes are actually working. Thanks!

probonopd commented 5 years ago

This appears to be resolved in appimaged 1c7986a, thank you.