search

AppImageCommunity / libappimage

Implements functionality for dealing with AppImage files
https://appimage.org
Other
46 stars 29 forks source link

Print name of file that is "Unknown AppImage format", closes #102 #108

Closed probonopd closed 5 years ago

probonopd commented 5 years ago 
Expected: core::AppImage("/libappimage/tests/data/" "/elffile").getFormat() throws an exception of type core::AppImageError.

No clue why the test fails now. @azubieta please help.

TheAssassin commented 5 years ago

You can't simply remove exceptions. They're part of a function's contract. This exception is expected to be thrown by the unit tests. You must restore that behavior.

probonopd commented 5 years ago

I wondered why in this location the error message printing works different than in other similar-looking places a few lines below. I think it is inconsistent, and wanted to make it more consistent with other warnings.

probonopd commented 5 years ago

This seems to have worked, at least the build succeeded. Now, how do I test this with appimagetool? (Before everything was split into multiple repositories, this PR would have built a new appimagetool too, point in case for why I want a monorepo.)

Without resorting to local compilation (which I never do) I have to merge this in the hope that it doesn't break things, and then trigger a build of appimaged. Possibly I need to update the appimaged repository in case it is linked to a certain commit of libappimage. None of this is documented.

probonopd commented 5 years ago

Feel free to revert if this breaks something.