search

AppImageCommunity / libappimage

Implements functionality for dealing with AppImage files
https://appimage.org
Other
46 stars 29 forks source link

Use cairo and rsvg libs directly #118

Closed azubieta closed 5 years ago

azubieta commented 5 years ago

Make libappimage use cairo and rsvg directly instead of dlopen it.

Also considered creating some kind of options to choose which backend to use at build time but it would mean adding a lot of conditionals in the build code and we have already too many. I would prefer to keep it simple (if that phrase could be used at this point :D ).

The old code wasn't dropped, instead was moved to a separated and disconnected class.

Reviews are welcome

TheAssassin commented 5 years ago

How well is that new implementation tested?

Why did the builds fail? Ah right, lack of rsvg in the containers, working on it, sorry.

azubieta commented 5 years ago

Nothing changed (except for the dlopen part) from the old implementation. An it's covered by the tests cases the are already in place

TheAssassin commented 5 years ago

Have you triggered a rebuild already? The images have been updated with librsvg2.