search

AppImageCommunity / libappimage

Implements functionality for dealing with AppImage files
https://appimage.org
Other
46 stars 29 forks source link

Crash on Firefox desktop file #120

Open probonopd opened 5 years ago

probonopd commented 5 years ago

AppImageLauncher crashes on Tumbleweed

linux@localhost:~> AppImageLauncher --appimagelauncher-version
AppImageLauncher version 1.2.2 (git commit 9aedcf2), built on 2019-05-24 14:44:52 UTC

linux@localhost:~> cat /etc/os-release 
NAME="openSUSE Tumbleweed"
# VERSION="20190521"
ID="opensuse-tumbleweed"
ID_LIKE="opensuse suse"
VERSION_ID="20190521"
PRETTY_NAME="openSUSE Tumbleweed"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:opensuse:tumbleweed:20190521"
BUG_REPORT_URL="https://bugs.opensuse.org"
HOME_URL="https://www.opensuse.org/"
LOGO="distributor-logo"

linux@localhost:~> md5sum /home/linux/Applications/Firefox-66.0.5.glibc2.4-x86_64.AppImage
8b63b3ac417964b6833bbb824b6a8f71  /home/linux/Applications/Firefox-66.0.5.glibc2.4-x86_64.AppImage

linux@localhost:~> gdb appimagelauncherd
r # "run"

Thread 2 "Thread (pooled)" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff28f9700 (LWP 6791)]
0x00007ffff72e2c83 in desktop_integration_modify_desktop_file (
    appimage_path=appimage_path@entry=0x7fffec003aa8 "/home/linux/Applications/Firefox-66.0.5.glibc2.4-x86_64.AppImage", 
    tempdir_path=tempdir_path@entry=0x7fffec01d0c0 "/tmp/libappimage-W48I2Z", 
    md5=md5@entry=0x7fffec01c860 "6eb6c827468db3390ab464f56d25dbc8")
    at /home/travis/build/TheAssassin/AppImageLauncher/lib/libappimage/src/libappimage/desktop_integration.c:310
310 /home/travis/build/TheAssassin/AppImageLauncher/lib/libappimage/src/libappimage/desktop_integration.c: Datei oder Verzeichnis nicht gefunden.
TheAssassin commented 5 years ago

Crashes on Nextcloud 2.5.2's AppImage as well.

azubieta commented 5 years ago

This error is from the 0.1 versions of libappimage. Would you please verify which commit is actually being used?

@probonopd would you please provide a link to the offender Firefox AppImage?

@TheAssassin I wasn't able to reproduce the Nextcloud 2.5.2 AppImage issue using libappimage v0.1.x-legacy on Neon.

probonopd commented 5 years ago

https://bintray.com/probono/AppImages/download_file?file_path=Firefox-66.0.5.glibc2.4-x86_64.AppImage

TheAssassin commented 5 years ago

@azubieta as I wrote in https://github.com/TheAssassin/AppImageLauncher/issues/127#issuecomment-495952524, the error goes away when AIL is built on the test system. I also have no idea what could cause this, my best guess is that it's due to some GLib ABI differences or so.

probonopd commented 5 years ago

Why not use the glib function to get the keys rather than doing it low-level?

azubieta commented 5 years ago

@probonopd in v0.1.x we do use glib functions to get the desktop entry keys. Or you mean other keys?

probonopd commented 5 years ago

@TheAssassin before I mix up our findings from yesterday, I let you explain (regarding counting the localized keys)

TheAssassin commented 5 years ago

@probonopd that's not guaranteed to be the root issue any more from my investigations.

probonopd commented 5 years ago

The same AppImage with the same AppImageLauncher does NOT crash on xubuntu-19.04-desktop-amd64.iso: 

me@host:~$ AppImageLauncher --appimagelauncher-version
AppImageLauncher version 1.2.2 (git commit 9aedcf2), built on 2019-05-24 14:45:41 UTC

Is it random or do we see a pattern?