AppImageCommunity / libappimage

Implements functionality for dealing with AppImage files
https://appimage.org
Other
46 stars 29 forks source link

Notify KDE about changed icons using dbus #123

Closed probonopd closed 5 years ago

probonopd commented 5 years ago

https://github.com/TheAssassin/AppImageLauncher/blob/9aedcf2cb308c6362bc7eed2b0ba88d388bb2079/src/shared/shared.cpp#L580-L585

When implemented in libappimage, this should not be done using Qt, though. Unless we switch libappimage to Qt.

Reference: https://github.com/TheAssassin/AppImageLauncher/issues/165

azubieta commented 5 years ago

Already investigated this and found that there are no dbus services listening to that signal. Please check the details here https://github.com/AppImage/appimaged/issues/88#issuecomment-497791314

azubieta commented 5 years ago

Right now we don't call any desktop update from libappimage, first we need to check if we want to do it. Second we should move all the known hacks (not only kde) to libappimage

probonopd commented 5 years ago

Yes. @TheAssassin wdyt?

azubieta commented 5 years ago

Already investigated this issue and the dbus call has no effect so far. This also seems to be a duplicated of #29 Will close the issue and the discussions about moving desktop update hacks could continue on #129 Please feel free to reopen it if required.

probonopd commented 5 years ago

the dbus call has no effect so far

@TheAssassin why are you using it in AppImageLauncher?

TheAssassin commented 5 years ago

I was told this might help in some chat, IIRC. It certainly can't hurt, I'm using Qt anyway, so DBus is easy to use.