AppImageCommunity / libappimage

Implements functionality for dealing with AppImage files
https://appimage.org
Other
46 stars 29 forks source link

Add method to fetch version during runtime #126

Open TheAssassin opened 5 years ago

TheAssassin commented 5 years ago

When #124 is done, we should add a method returning a version string for use on runtime. Might come in handy when displaying versions.

azubieta commented 5 years ago

I guess that we decided to not doing this on https://github.com/AppImage/libappimage/issues/97 Please review.

TheAssassin commented 5 years ago

Version string != available features. This is mostly useful for about dialogs, bug reports, etc. For instance, I'd like to display some library versions in AppImageLauncher's settings dialog to ease bug reporting in the future.

To me, returning the contents of a #define would be fine, too, but the abstraction of having a function allows for future changes (e.g., adding feature names or so to the version string (not for use to check for features)).