AppImageCommunity / libappimage

Implements functionality for dealing with AppImage files
https://appimage.org
Other
46 stars 29 forks source link

MIME files deployment not working #141

Closed TheAssassin closed 5 years ago

TheAssassin commented 5 years ago

libappimage 1.0.0 deploys MIME data in an incompatible way.

From what I can tell from the code, it tries to export the usr/share/mime/packages/ directory from the AppImage to ~/.local/share/mime/appimagekit_XXXXX_packages. However, the code isn't tested very well, and what it actually does is copy the only file contained in the directory into a new file with the path mentioned above.

I manually fixed the issues, but that didn't make it work either. What should be done is extract all files within usr/share/mime/packages/ into ~/.local/share/mime/packages/appimagekit_XXXXX_original_filename.xml. I've tested that, this works perfectly fine.

The code is a bit confusing and lacks comments, also many helpers aren't documented. I'll try to fix that with a PR soon-ish, but it might take a while. Though, I consider this a priority issue to fix, since MIME integration is really awesome to have with AppImages. For instance, I use Xournal++, FreeCAD, Scribus and many other apps, and I don't want to have to open them manually with the tools.

TheAssassin commented 5 years ago

We'll make a bug fix release once this has been resolved.