search

AppImageCommunity / libappimage

Implements functionality for dealing with AppImage files
https://appimage.org
Other
46 stars 29 forks source link

Missing symbols #177

Open ScarlettGatelyMoore opened 1 year ago

ScarlettGatelyMoore commented 1 year ago

Hello! I am updating the package in debian and I have come across some missing symbols. From what I can see these are public: c++filt _ZN8appimage4core4impl14PayloadIStreamC1Ev appimage::core::impl::PayloadIStream::PayloadIStream() c++filt _ZN8appimage4core4impl14PayloadIStreamC2Ev appimage::core::impl::PayloadIStream::PayloadIStream()

Is this an internal call? Or do I have ABI breakage?

c++filt _ZNK5boost10filesystem28recursive_directoryiterator5equalERKS1 boost::filesystem::recursive_directory_iterator::equal(boost::filesystem::recursive_directory_iterator const&) const seems internal tests?

the rest are optional and not issues.

Thanks for any help in the matter. Scarlett

TheAssassin commented 1 year ago

I wonder how you detected these changes. Are you experiencing linking issues against other software? I'm not entirely sure how Debian handles C++ symbols.

I guess we need to rework how we export public symbols and need to hide all internal calls properly.

ScarlettGatelyMoore commented 1 year ago

https://wiki.debian.org/UsingSymbolsFiles

TheAssassin commented 1 year ago

This confirms my assumption. We need to properly export symbols before generating symbol files makes any sense.

ScarlettGatelyMoore commented 1 year ago

Any news on this?

ScarlettGatelyMoore commented 1 year ago

Even if you can confirm they are all internal and not exposed to public I can continue. Thanks