AppImageCommunity / libappimage

Implements functionality for dealing with AppImage files
https://appimage.org
Other
46 stars 29 forks source link

Require system lzma and libarchive #181

Open pinotree opened 1 year ago

pinotree commented 1 year ago
TheAssassin commented 1 year ago

If you really want to remove the local build options, you either need to make sure these libraries are available and recent enough in https://github.com/AppImageCommunity/AppImageBuild, our build environment.

The modified project no longer links the two libraries in question statically, which is likely to cause issues. Unfortunately, CMake's built-in pkg-config support doesn't support imported targets for static libraries as of yet, and neither does our own function.

pinotree commented 1 year ago

If you really want to remove the local build options, you either need to make sure these libraries are available and recent enough in https://github.com/AppImageCommunity/AppImageBuild, our build environment.

Hmm I saw that ci/install-deps.sh already had the system packages for them and assumed it was enough - OK, will take a look at AppImageBuild.

The modified project no longer links the two libraries in question statically, which is likely to cause issues.

Can you please expand on the reasons why this would be problematic? Usually you want to dynamically link to this kind of system libraries, as it makes less problematic to update users of them in case of e.g. bugfixes/CVEs/etc.