search

AppImageCommunity / libappimage

Implements functionality for dealing with AppImage files
https://appimage.org
Other
46 stars 29 forks source link

Consider using libcrypt #56

Closed azubieta closed 5 years ago

azubieta commented 5 years ago

https://www.freebsd.org/cgi/man.cgi?crypt(3)

probonopd commented 5 years ago

Why should we change a running system?

TheAssassin commented 5 years ago

I don't see the advantage. We already ship our own MD5 digest algorithm to not have to depend on "larger" libs. Apart from that, the library doesn't offer anything else of interest.

probonopd commented 5 years ago

Please don't introduce additional dependencies unless there is not a totally pressing need. We already have too many for my taste.

TheAssassin commented 5 years ago

We already have too many for my taste.

Such as?

I would be interested in getting rid of our own MD5 implementation, generally spoken. libcrypt isn't heavyweight either, probably has compatible license and can most likely be linked statically. However, I would want to hear why @azubieta suggests this. The issue doesn't contain any information on this...

probonopd commented 5 years ago

What is wrong about our current MD5 implementation? It works, we have no issues with it, so why touch it.

TheAssassin commented 5 years ago

It's random code from the Internet that never will be updated. It hasn't been reviewed in depth by me either. Also, we need additional hashing algorithms anyway for other purposes. And I don't necessarily want to maintain such dependencies myself, we don't need to like, ship MD5 another time to a system which already has a few dozens.

azubieta commented 5 years ago

@probonopd using libcrypt is your idea :) see the referenced comment at the top. I'm just extracting the issues that were exposed in the #33 review and can be delayed.

probonopd commented 5 years ago

Uh, ok, then it must be an old leftover. Has been solved a long time ago. Sorry for the confusion, closing.