AppImageCommunity / libappimage

Implements functionality for dealing with AppImage files
https://appimage.org
Other
46 stars 29 forks source link

Move resource extractor to the public api #82

Closed azubieta closed 5 years ago

azubieta commented 5 years ago

The ResourceExtractor allows locating relevant files (such as the desktop file, icons, and mime-types) also allows extracting files following symlinks in a resilient way.

The PR also replaces the old symlinks resolution code by using the ResourceExtractor solving #66

TheAssassin commented 5 years ago

Please fix the codacy warnings. Otherwise, it looks good.

azubieta commented 5 years ago

Fixed the codacy warning regarding the missing "explicit" before the ResourcesExtractor::Priv constructor.

The ones related to read are false positives. It's confusing that function call with the system one.